"Hades Generals Quest" - BUGFIX

[GuardianWarrior]

1. Post!

Revealing the Mystery around the "Hades Generals Quest"-BUG, ...

...which isn't realy one! ***looking big***

Yep, readed correctly, the quest works on all difficulty levels properly.

***looking even bigger***

__________________________________________________

CONTENT
1.) EXPLANATION
2.) TODO 2 FIX
............ a) Easy Update-Variant
............ b) Step by Step-Variant
3.) END
__________________________________________________


Preliminary remark
All DBR-Files which i show hereinafter, are from the IT-"database.arz"



1. EXPLANATION

The problem is, that changes in the damage-display often can't be seen, and for this
the players themselves are guilty, O), ehm well, thats of course not really true.
The point is, that the implementation of some questrewards has been done wrong and therefore these became vulnerable for quasi external influences. But through careful handling, this was prevented in all cases but one, namely the "Generals Reward".
As i said, the reward does work very well:
Make yourself a "naked" Test-Char (Char: Player-Charakter or Figure) with a cheat-program, with e.g. following stats:
1.000.0000 Life/Energy, 10.000 Str/Dex/Int, aktivate all portals;
With an ingame-cheat give yourself super runspeed, 400-600.
Scurry through the game and make the all the 3 "Generals-Quests" and you will see, it works.

Why does it work in the "General-Case", only on "Normal"-Difficulty everytime, but else mostly not?
But on the other side, why does it work in test-cases like the one above again?

Let`s have a closer look into it:

The first difference to the other quests can be seen in the following DBR-File:
records\quests\rewards\questrewardskilltree.dbr (listing of different questrewards)

IMAGE

The darkgrey marked line is the interesting one, where on the left side stands "skillName16" and on the right, the relevant DBR for the questreward, "xSQ27 - TotalDmgBuff_All.dbr".
All here entered quests are implemented 3 times, for every difficulty-level is one entry with the according DBR-File. But for the "HadesGenerals" exists just one entry and one DBR, which leads to the second difference, namely to this, that all 3 values for the reward have to be entered serial in one row in the same file, which is in the end already the very whole fault!
And exactly because of this, a special mysterious "influence" interferes. So it often appears, as if it doesn't work, and thereby makes the player to a "Quasi-Culprit" or also to a "Quasi-Cheater"! O)

Let`s have a closer look on this file:
records\xpack\quests\rewards\xSQ27 - TotalDmgBuff_All.dbr

IMAGE

The second difference is shown here more clearer:
The darkgrey marked line shows, which reward the player should get: 5, 10, 15 %Total-Damageincrease. Which means, 5% for the first time when the quest has been done, 5% for the second time, together with the 5% from the 1. time it`s a total of 10%, 5% for the 3. time, together with the 10% from the 1. and 2. time it`s a total of 15%. The values are indicated as a summation and the real rewards are the differences of these.

Why then not 5,5,5?

Thereto i have to mention first, that some questrewards were given in another way according to the storing in the "savegames". This i have chalked up at the top of the first paragraph, as a quasi implementation-error. The ones listed in this file "questrewardskilltree.dbr" are affected. (see picture above)
In the "player.chr" (be found in the savegame-folder of the player-chars) there will be saved quasi only links, which refer to the reward-DBR´s (be found here: records\xpack\quests\rewards\).
Which means, these will then quasi not be saved hardcoded in the char, and therefore must be read once again with every start of the game!
Here a outline, as example the entry for the "Generals-Questreward":

skillEnabled
skillSubLevel
skillActive skillTransition end_blockÞÀ Þ
begin_blockÎú ° skillName9 Records\XPack\Quests\Rewards\xSQ27 - TotalDmgBuff_All.dbr
skillLevel

(Used program: UltraEdit; ASCII-Mode)

With finishing the quest, you get this quest-entry and therefore the reward.
Happens just the 1. time, cause for the 2. and 3. time, the values are in the same DBR-file and there is only this one DBR-file. A second entry would look consequently exactly the same, but that is prevented by the program.
(tested this one through)
Which means, the questreward is actually given just once!
But through an index-value the exact position is specified, which reward-value should be taken out of the entry-field. Therefore the values (5,10,15) shown above in the picture are indicated as a summation.
An entry like 5,5,5 therefore would make no sense, cause you would never get more then the 5%.
The index-value is indicated at "skillLevel" (last line), the strange check mark (it`s an ASCII char) behind, and through that the game knows, if now 5, 10 or 15% should be given.

Remark:
After error correction here should be 3 entries, as with the other quests, which are in the "player.chr" directly above or below (if finished), and as with the "questrewardskilltree.dbr".
(when you have finished all the quests)

The quest although works properly, but for the 2. and 3. time, the initially
mentioned implementation-error comes to bear, which was not corrected here.

The above mentioned mysterious "influence" exploits this, cause
this one comes from the player himself,
more precisely from his items, which he uses!
(=> therefore "Quasi-Culprit")

***looking realy very big***


What for an influence then?

What does this picture tell you for example?
The darkgrey marked line shows the values for the skill-attribute +X% damage per level.
Does the way like the values are arranged look familiar to?

IMAGE

Yes exactly, looks the same like the above shown "xSQ27 - TotalDmgBuff_All.dbr": 5, 10, 15.

Well, already have a clue?

From the mastery-skills we know, that the values of them logically increase, when we invest more skill-points in it, use +skillbuff-Skills(Battle Standard) or also use +skill-items. Of course there must be invested already one point into the certain skill, to become active.

What does now +Skill-Items have to do with the pretended bug of the "Hades Generals Quest" ?

1.) Keyword: Entry in the "player.chr"
2.) Keyword: Implementation-error

If you look closer into the "player.chr" on the part where the mentioned quest-entries are, so you find above and below also all quasi learned skills of the player-char.

The quest and skill entries look realy similar, doesn't they?

Outline thereto(Skill-example):

skillEnabled
skillSubLevel
skillActive skillTransition end_blockÞÀ Þ
begin_blockÎú ° skillName/ Records\Skills\Nature\HeartofOak_Permanence.dbr
skillLevel

Compare with the outline above.
(See also the entires in the "questrewardskilltree.dbr")

"IDEA":
A suspicion comes up, that these quests, were just handled like skills!!!
(...what i have above always mentioned as implementation-error!)

Why then mostly can't be seen any change at the damage-display after the 2. or 3. completion of the "GeneralsQuest" ?

Quite simple, the first time, the quest will be activated, like a skill, and you can see the change. At the 2. or 3. time normaly you have already so much "+Points to all Skills" from items, that you have already reached the "Cap" for the quest and therefore no changes can't be indicated anymore. The "Cap" lies obviously at 3, for the 3 times per difficulty-level and in the "xsq27 - totaldmgbuff_all.dbr" (see picture above) there are only 3 values entered on the shown position (darkgrey marked line).

Example:
Quest 1. time done, reward received;
Equipment has a total of +2allSkills;
Quest has therefore in all, 3 skill-points;
The game now searches for the value in the 3. position and takes this one instead of the 1. one;
In the "xsq27 - totaldmgbuff_all.dbr" (darkgrey marked line) on the 3. position it says 15;
=> Indicated damage-increase is not 5%, what it should be, but full 15%.

In plaintext, every player can have more reward as he deserves, when he uses equipment with "+X allSkills".
(=> therefore "Quasi-Cheater")
(!!!Attention: +Skills on a certain mastery, don't work!!!)

A test to make for yourself:
In the "xsq27 - totaldmgbuff_all.dbr" behind 5, 10, 15 enter 3 more values, e. g. 50, 100 , 1000.
Has your Char done all 3 quests and also +3 allSkills (Stonebinders), then you should have a damage-increase of +1000%.

HOLA, amazing!

So, that is the secret behind the "Hades Generals Quest"-BUG.


Remark:
In this whole explanation i have tried to state the experiences i have made and the collected ideas as simple as possible, to give the whole topic textual a certain direction resp. a red thread. Of course, and that`s what i wanted to say with this remark, for me the whole thing went a different way, because i have done intensive and time-consuming ingame-tests. The above mentioned explanations should additionally show, what there is all behind.

A special mystery for me was:
One Char i have (skill only in Hunting, so just one mastery), was through "Normal" and "Epic", standing at the beginning of "Legendary" (no quests done so far). A second Char, which was a copy from the first one (became a Ranger then), i played on, till directly before the "Generals-Quest".
Interestingly enough, after many attempts, the first Char got the questreward everytime, the second one never.
Something seemed to be wrong with the 2. Char.
So for now i thought that the quest itself works, and also someone from here in this forum, was 100% sure that it was not bugged, but obviously couldn't explain why.
I thought to myself, maybe there is a certain ingame-trigger, which through an error gives the reward on the "GeneralsQuest". So i played the whole game through and searched for abnormal changes while doing every quest.
To be lucky for me, this wasn't completely for nothing, because the number of the suspected opportunities decreased drastically.
A comparison of damage-values from before the quest and afterwards resp. to every single equipped item, then revealed, that something is wrong with the artefact "Toth´s Glory", to be more precisely, with one of it`s attributes.
*Bingo*
The +1 to all skills was guily for the whole misery.

So, ends well, all's well.
The solution is to make three implementaions of the questreward-DBR, details follow now.



2. TODO 2 FIX


Preliminary remark:
All files hosted by me, are principally available to an unlimited time period, but at least the next 2 years, from creation date of this thread. I will see to a prolongation if necessary.
The pictures are made deliberately in a lower quality, but are still good readable.

2. Preliminary remark:
For playing online, everybody should use the same fix, if this fix has modifications concerning the databases and archives.
This does not mean, that everybody has to use my fix, but all players should have done the same modifications of the databases and archives.


A) EASY UPDATE-Variant

Generals+StygianBUGFIX-Paket (~ 22MB)

!!! I M P O R T A N T !!!
This is no "Plug & Play"-Variant, because you have to go through parts 3.-5. from the "STEP by STEP"-Variant.
But for that, look at the attached "#_Readme.txt". Also for Infos on "Stygian Monster Quest"-Bugfix.

--------------------------------------------------------------------------

UPDATE: CameraMod
==============

The Download-Package includes now 3 IT-database-files:
database.arz (with original camera-positions)
database_ISOMETRIC.arz
database_TOPDOWN.arz

The last two are enhancements of the first one, where the camera-position has been changed, as done in the CameraMod.
See picture for DBR-Entries:

IMAGE

To use the last two, just rename them into "database.arz" and copy it into this directory:
"C:\Titan Quest Immortal Throne\Database\"

The infos for this i have from "Deighvyd's Immortal Throne Camera Mod Collection v3.2"

--------------------------------------------------------------------------


B) STEP BY STEP-Variant

Self-made in 10 steps.

__________________________________________________

CONTENT
- Tools
- Files
- Remark to "Stygian Monster" QUEST-BUG
- General Remarks
- 1. Part: IT-Database rebuilding
- 2. Part: IT-Questarchive rebuilding
- 3. Part: Questlog
- 4. Part: Playing
- 5. Part: Summa summarum
__________________________________________________


Required TOOLS:

- ArtManager
- Quest Editor
- ArchiveTool (is in the main-directory of TQ and IT) or use another ARC-Unpackingprogram, i have used ArcExplorer.

Originally i have it from here: ArcExplorer
Hosted by me: ArcExplorer


Following FILES from IT will be influenced:

-database.arz (rebuilding)
-questrewardskilltree.dbr (editing)
-xsq27 - totaldmgbuff_all.dbr (copying, renaming und editing)
-quest.arc (rebuilding)
-xsq27_hadesgenerals.qst (editing)


Remark to "STYGIAN MONSTER" QUEST-BUG:

This fix was also done here, because the same file had to be edited.
Originally, i have this one from here, in the first Post:
Titanquest.net Forum


Two preliminary REMARKS:

- To get a quick overview, it could be worth to read only the first line of each step.
- ArtManager will be needed for parts 1+2, so you can leave it open till the end.


1. Part: IT-Database rebuilding

[1. Step] Create an empty mod. (doesn't need to have a map)
Open ArtManager.
In the menu-bar on top click on "Mod\New...".
In the field "New Mod Name" enter any name for the mod and click "OK".
In the menu-bar click on "Build\Build F7".

[2. Step] Replace the database.
Go to your workingplace or open the explorer.
Go into the build-folder of the mod (if you dont't know where, O), could well be, then click on "Tools\Options..." in the ArtManager).
In the subfolder "database" is an ARZ-File with the mod-name("Mod-Name".arz).
Replace this one with the original database "database.arz" from IT (or the one you are having in use right now, in case it's already modded) and give it the same name as the ARZ-File of the mod.
My original IT-Database is located here: "D:\......\Titan Quest Immortal Throne\Database", the place where i have installed IT.

[3. Step] Import DBR´s.
Go back to the ArtManager.
In the menu-bar click on "Database\Import Record...".
Select the following database-files (only one by one possible):
a) records\quests\rewards\questrewardskilltree.dbr
b) records\xpack\quests\rewards\xsq27 - totaldmgbuff_all.dbr

[4. Step] Edit DBR´s.

- [3. Step] a) edit as follows:

IMAGE

Remark to "Generals Quest":
The 3 lines titled with "skillName19, 20 and 21" show on the right side the entry,
"records\xpack\quests\rewards\xSQ27 - TotalDmgBuff_.......dbr",
which will be copied into the "player.chr", after the completion of the quest. Thus every single registered "Generals-Quest" will be applied as a Char-Skill, which will be aktivated when reloading the Char (Player-Charakter or Figure) and thereby the quest-reward will be charged. Therefore this 3 entries are necessary.

Remark to "Stygian Monster Fix":
The 3 lines titled "skillName16, 17 and 18" with the following entries on the right side:
"records\xpack\quests\rewards\xSQ13 - StrDexIntBuff_.......dbr"
are missing in the original file, but are necessary for a permanent receipt of the quest reward, because these will then be copied into the "player.chr", after quest completion. Funnily and to be lucky for us, apart from that the quest is fully implemented, only these 3 entries are missing.
Why do we get the quest reward right after completion?
Well, there is also the archive "Quest.arc", where within for each quest exists a separate file. In this case, "xsq13_stygianlurker.qst".
The quest-database will also be accessed from this QST-Files, in this case again one of these: "xSQ13 - StrDexIntBuff_.......dbr".

- [3. Step] b) Make 2 copies and rename all 3 files into:
"xsq27 - totaldmgbuff_normal.dbr"
"xsq27 - totaldmgbuff_epic.dbr"
"xsq27 - totaldmgbuff_legendary.dbr"

and now edit as follows:

"xsq27 - totaldmgbuff_normal.dbr"

:this is more cosmetically editing. Must not be, but who wants, for the other two files i haven't made a picture, but at the end of this step another picture will show what i have edited there.






"xsq27 - totaldmgbuff_epic.dbr"





"xsq27 - totaldmgbuff_legendary.dbr"




Remark:
As explained in my detailed "Explanation" above, for the correction of the defect (mysterious influence), which appears because of items with +allSkills, a splitting of the questreward onto 3 separate files, one for each difficulty level, is necessary. As you can see in the pictures, now just one entry is necessary, and this is 5. 10 and 15 are not needed anymore, because when reloading the Char, as explained above under "[4. Step] - Point 3.)a)" in the 1. remark, the questrewards will be uploaded and with 3 entries with 5% each, this will result in 15% total (assuming all the quest are done).

After pressing the "Database"-Tab in the ArtManager, it should look somehow like that:

IMAGE 1

IMAGE 2


[5. Step] Rebuild the Mod.
In the menu-bar above click "Build\Build F7".
If a window appears during the building process with the following titel "Confirmation", then just click "No to all", on the very right side.

[6. Step] [2. Step] reverse: Replace database back. (make backups!)
Go to your workingplace or open the explorer.
Go into the build-folder of the mod, and then into the subfolder "database".
Copy the new builded database ("Mod-Name".arz) into the "Database"-Folder in the main folder of IT and rename it again into "database.arz".


The database part is now done and we come to...


2. Part: IT-Questarchive rebuilding

[7. Step] At first, the file "xsq27_hadesgenerals.qst" has to be extracted from "D:\Titan Quest Immortal Throne\Resources\XPack\Quest.arc".
For that i have used the tool "ArcExplorer". Comfortable to use. Can only extract, but that doesn't bother here. The link is above in the capter-part "Required TOOLS". The tool is simple to use, so i guess it won't need any further explanation.
Alternatively you can also use "ArchiveTool", it is in the main-folder of the game.
If you need help on this, you can open the command-console ("cmd.exe"), go into the main-folder of the game and typ "archivetool". Then the syntax will be shown how to use the tool. Or try the search function here, maybe there are any explanatory threads around.

[8. Step] Edit "xsq27_hadesgenerals.qst".
For this open the "Quest Editor" and under "File\Open..." search the extracted "xsq27_hadesgenerals.qst" and open it.
Nun wie folgt editieren:

Original Version_Picture 1

Original Version_Picture 2


New Version_Picture 1

New Version_Picture 2


[9. Step] Add edited "xsq27_hadesgenerals.qst" to the mod.
In the ArtManager click on the "Souces"-Tab below.
Unfold the mod-folder and go into the quest-folder.
There in the right window press right-click and select "Import...". Then in the explorer-window search for the edited "xsq27_hadesgenerals.qst", mark it and click on "Open" below.
Should look like this:

IMAGE

Now right-click onto the file and click on "Auto-Create Asset" at the bottom of the popup-window.
Click onto "Assets"-Tab below.
Should look like this:

IMAGE

Then in the menu-bar above click "Build\Build F7".

[10. Step] Rebuild questarchive. (is more or less the same as with the database)
- The file "Quest.arc" we have already used in step 7.
Take this one, go into the build-folder of the mod and replace the identical one in the subfolder "resources".
- In the ArtManager in the menu-bar click on "Archive\Build...".

Remark:
!!! DON'T !!! click on "Build\Build F7" or "Archive\Compact...".
Because then, all in the mod not used quest-files, and we just have only the one from the "Generals-Quest" imported, will be deleted from the archive, which will become useless for further usage for the game.

- With this newly built "Quest.arc", we now replace the original "Quest.arc", that we copied before into our mod. (make Backups!)


Working with the tools is now over and we come to the first steps, that have to be done before gaming...


3. Part: Questlog

"Generals Quest"
A loud and joyful "H O O R A Y !" for us all.
For everybody who has already done the quest, it will be deleted automatically from the questlog!
Reason for that is the linking of the quest with new DBR-Files.
With it, the char is loosing it´s original rewards (damage-indicators loose value), but which was not given correctly before, but is now able to do each quest again and gain the correct rewards.
The 2. und 3. time it could be enough, to just talk to the quest-giver:
"Elpenor - Hero", standing beside Odysseus. Just try it out.

Just for additional information:
In this file "cbbed5b321b2d27e609f6d97ee167727.que" are the relevant entries to the "HadesGenerals"-quest.
Particularly the references to the appropriate questfile "xsq27_hadesgenerals.qst".

"Stygian Monster Quest"
Here unfortunately, the quest remains, but
we just have to delete the following file: "3a5748602b907731288ccc4a12be30ea.que"
from any of these directories:

"C:\Documents and Settings\<Windows Login Name>\My Documents\My Games
\Titan Quest - Immortal Throne\SaveData\Main\_CHARNAME\Levels_World_World01.map\Normal"
"C:\Documents and Settings\<Windows Login Name>\My Documents\My Games
\Titan Quest - Immortal Throne\SaveData\Main\_CHARNAME\Levels_World_World01.map\Epic"
"C:\Documents and Settings\<Windows Login Name>\My Documents\My Games
\Titan Quest - Immortal Throne\SaveData\Main\_CHARNAME\Levels_World_World01.map\Legendary"

...and this for every char which has done the quest already.
For each difficulty-level you just have to talk to the quest-giver:
"Copreus - Hunter Shade", who is standing near the "Styx"-Portal. Then the reward will be permanent.
Alternatively, and if the QUE-File is the wronge one, contrary to all expectations:
Open up commandline-console (cmd.exe), go into every of the 3 directories and execute the following command:
findstr /M "xsq13_stygianlurker.qst" *.que
That will show you definitely the proper file, which you should delete.


4. Part: Playing

Before you start playing wildly again:
With every Char you have and which has done the "Generals"-Quest at least one time,
first of all go into the game and leave it right afterwards.

You should do this, because in the "player.chr" is still the old entry left, remind this one:
"skillName9 Records\XPack\Quests\Rewards\xSQ27 - TotalDmgBuff_All.dbr"
see also the first extract from the "player.chr", which i have shown above in the "EXPLANATION"-part,
and also under "[4. Step] - Point 3.) a)" in the 1. remark.

As long as you don´t leave the game, this entry remains and therefore also the original problem!

This old entry will be deleted automatically when leaving the game.
To be lucky for us, so that we don´t have to do this also on our own.

As a consequence, after reloading the game, the damage-values will be shown correctly.


5. Part: Summa summarum

- Replace files: "database.arz" and "quest.arc"
- Start the game with your Char,
- immediately afterwards jump out of it,
- then load it again,
- make the Quests again (for each difficulty level),
- get the rewards,
- and smile.



3. End well, all's working!


So, now that was all i have to say to this topic.
I thank you all, who managed to do it till here with reading, for your attention and i'm ready to reply any, "reply's and answers".

I hope you enjoyed all the pleonasm's i used. I didn't want to rack my brain in finding better expressions while translating this text and it saved me a little bit of time too. But if you find any errors or can suggest any stylistc improvements, just write me a pn or make a post here, thank you.

Originally this thread was first posted by myself in the german forum "Titan Quest HQ - Tempel".

What will i do next?
Well, i'd like to have this bugged skill "Triumph" working.
But at the moment i have not much time left, so we'll see how long it takes.

Meanwhile, i wish you all much fun with playing the game.

[Fix discovered and made by GuardianWarrior]

[GuardianWarrior]

WOW, OVER A HUNDRED VIEWS, BUT NO COMMENT !


WHAT´S GOING ON HERE ?




IS THIS THE MOST FREQUENTED TQ-FORUM ?


WHAT A SHAME !




Hm ok, maybe i should have explained something previously:
This thread is just a translation of the german version. Therefore it is not adapted to this forum here, concerning the background- and info-level of the members here. Sorry that i didn´t do this, because it is a long thread and a lot to read.

I have figured out, that most of you think, that this bug is just a display-bug. But it is not!

Although the quest is bugged, there is a ingame-way to get the whole 15% total damage. After you have done the quest the first time(5% total damage), you can get the reward for the other two difficulty levels, with using equipment that has the attribute "+X all Skills". So you need +2 to get 10% more of the total damage.

The second part of my thread offers a fix to this. So, you have the choice to fix it(as it was meant to work), or leave it as it is, cause most high level chars will have +allSkills.


Greetings,
GW

[yerkyerk]

Big post indeed, didn't read all of it.

So, if you equip +2 to all skills (or more), it will work? Well, that's fine by me.

Thanks very much for making this clear! And for putting up the crapload of info nobody's going to read on here, ofcourse =)

[Poinas]

I bet many have read it, but what can you say?

Well done.

The text itself is WAY too long, has terrible layout, seems very messy.

[GuardianWarrior]

Well, layout is of course not the best(but i think not realy terrible), cause after all the work, i wasn´t in the mood to do it properly. Also because previewed posts have a different layout than submitted posts and line indentation is not possible too.

@long text
OK, i have made a little adventure out of reading the explanation. Reading the whole post at once does take some time, but it is clearly devided into parts. I did go more into the details, so that people with less database knowledge could understand what´s it about.
But on the otherhand, i should have made also a short version without the database explanation, for people who don´t want to make up their mind about that.

[HeMan]

just wanted to say that this thread is excellent!
helped me a lot to understand the file structure of TQ and I think it is amazing work to find out all the stuff about this bug :-)
thx!

[yerkyerk]

About that; I've heard that the fix doesn't work correctly with the fanpatch. Anyone care to test if that's true?