"Triumph-Bug" : Another solution !

[GuardianWarrior]

Ok, this time no long explanations.
If you have any questions afterwards, just post it or pn me and i try to answer it as good as i can.

With my solution, the Debuffs from Triumph will work as they should.

EDIT: The attribute for the damage reduction didn´t work. With the Help of "ShadowLich" and his altered "SkillBuff_Passive.tpl", it does work now.

Just a few little side effects remain.

There are two major problems with the Triumph-DBR, the used Template and more important, the DBR-Implementation.

The values in the Triumph-DBR are set correctly.

EDIT: I did minor changes to my BS- and T-files, but they are not necessary for the bugfix. They are listed in this post, under point "@Raw DBR-Files -> Additional Changes".
There at the bottom, you also will find my raw DBR-Files for download.

EDIT: For information about "Ganelon"´s version of Triumph-Bugfix, please visit his thread.

---------------------------------------------------------------------------

Here is a list of the Standard and Triumph database files:

\records\skills\warfare\

1) battlestandard.dbr................................ .....Mainstart-File
2) battlestandard_petskill_default.dbr............... .StandardAbility-CallFile
3) battlestandard_petskill_defaultbuff.dbr........... StandardAbilities-DefinitionFile
4) battlestandard_petmodifier_triumph.dbr..........Tr iumphstart-File
5) battlestandard_petskill_triumph.dbr............... .TriumphAbilities-DefinitionFile

\records\skills\warfare\pets\
6) battlestandard_XX.dbr for XX = 01 to 14.........SideStart-Files

Call-Sequence:
1) -> 6){depending on Skill-Level one of the 14 DBR´s} -> 2) and 5)
2) -> 3)

---------------------------------------------------------------------------

The Call-Sequence shows that 5) is called directly from 6),
whereas 3) is called from 6) via 2).

This 2) is a special DBR, that calls 3) via a certain Template.
That´s the major key in this case!
So, i have made a similar file as 2), a "TriumphAbility-CallFile", and put it in between of 5) and 6).
To be lucky for us, this "similar file" is already in the TQ-database.arz

---------------------------------------------------------------------------

Here are four short steps to get Triumph working:

>>> Make an empty mod <<<

>>> Rename 5) and configure it <<<
a)
Import "records\skills\warfare\battlestandard_petskill_tr iumph.dbr",
b)
Rename to "battlestandard_petskill_triumphbuff.dbr".
c)
From the menubar select "File/Set Template...", go into the Template-Folder and
select following file: "SkillBuff_Passive2.tpl".
EDIT: This is the Template from "ShadowLich", which can be downloaded at the bottom of this post.
d)
Open the file and go "All Groups/Cast Config" and
set "skillActiveDuration" onto 4 seconds.
(*this step is explained below, see point 1*)
e)
Go to "All Groups / Skill Config" and
set "distanceProfile" to "Moderate".
f)
(*Do this one if you like to have Flamewaves radiating from the monsters.*)
(*This step is explained below, see point 4.*)
Open "battlestandard_petskill_triumphbuff.dbr"
go to "All Groups/Skill Effects"
copy "Records\Effects\Warfare\WarBanner_FX01.dbr" from
"skillActivatedAuraName" to "skillCastAuraName".
g)
Click "File/Save".

>>> Make new DBR from old one <<<
a)
Import "records\skills\warfare\old\battlestandard_skill02 .dbr"
b)
Rename in "battlestandard_petskill_triumph.dbr" and copy to "records\skills\warfare\"
c)
Open the file and go "All Groups/Skill Config" onto DBR-Entry "buffSkillName",
and edit path and filename as follows:
"Records\Skills\Warfare\battlestandard_petskill_tr iumphbuff.dbr"

>>> Build the mod with TQ- or IT-database.arz, it doesn´t matter which one. <<<

---------------------------------------------------------------------------

Ok, now to the little side effects:


1.
Explanation to the step from above: ">>> Rename 5) and configure it <<< - d)"
Without setting "skillActiveDuration" with a certain value,
the Debuffs from Triumph would last permanent, even when Standard is gone.
Thats not what we want to have.
So the value from "skillActiveDuration" stops Triumph working after Standard disappeared.
Understand,
Triumph gets triggered in certain intervals.
The value from "skillActiveDuration" bridges the gap between the intervals, and
each triggered Triumph lasts again the X seconds set with "skillActiveDuration".
So Triumph lasts as long as the Standard does.

The little down side to this is,
Triumph lasts this X seconds from "skillActiveDuration" longer than the Standard does.
So, after the Standard is gone, Triumph still works these few seconds.

The problem is, these X seconds from "skillActiveDuration" can´t just be set to 1,
because then it would not bridge the gap, and with a to long value, Triumph would
last to long after Standard is gone.
For me, 4 seconds worked as a good compromise.

2.
The approx. 4 seconds Start-Delay of Triumph.
Didn´t found any solution to this either.
I have tried out something in these DBR-files:
"\records\skills\warfare\pets\battlestandard_XX.db r for XX = 01 to 14"
with following entries: "AllGroups/Skill Configuration/specialAttackTimeout" and
".../specialAttackDelay", but it was fruitless.
A little drawback, that we have to accept by now.

3.
Triumph-Radius.
This on seems to be a little shorter than the one from Standard!
Take a char and go to the edge of the Standard-Radius, just before the
char-aura disappears. Lure a monster onto the same position beside your char,
so that it has the same distance to the Standard.
On that position the Debuffs of Triumph don´t work.
When you lure the monster just 2-3 steps nearer to the Standard,
Triumph starts to work.
Changing the distance profiles in 5) and 6), didn´t solve the problem,
except to make the Triumph-Radius far greater than the Standard-Radius.
But that´s not what we actually want to have.

4.
Flamewaves.
If you liked them, sorry, now they are gone.
I couldn´t manage it, to bring them back, but i was able to cast them on the enemies.
See ">>> Rename 5) and configure it <<< - e)" above, what to do.
Now the Flamewaves radiate from every enemy within Triumph range.
That´s very handy, cause it tells you when and at which radius Triumph starts to work.

5.
One thing left to mention and i guess this needs to be adapted, the Standard´s Lifetime.
Ever recognized, that the ingame attribute description shows 2 lifetime values?!
In white color it says:
Battle Standard Attributes: Life Time X Seconds
and below in blue color,
Battle Standard Abilities: X Second Duration

Here the entry of the "battlestandard.dbr" ->
-> "All Groups/Spawn Config/spawnObjectsTimeToLive":
spawnObjectsTimeToLive,18.000000;20.000000;22.0000 00;24.000000;26.000000;28.000000;30.000000;32.0000 00;34.000000;36.000000,
Btw, just 10 values here, not 14 to the skillcap.
And here the entry of the "battlestandard_petskill_defaultbuff.dbr" ->
-> "All Groups/Cast Config/skillActiveDuration":
skillActiveDuration,20.000000;26.000000;32.000000; 38.000000;44.000000;50.000000;56.000000;62.000000; 68.000000;74.000000;80.000000;86.000000;92.000000; 98.000000,

Well, ingame-check showed, that the Standard only has a lifetime as indicated in the "battlestandard.dbr". Means, on lvl 10 a lifetime of 36 seconds.
The other values from the "battlestandard_petskill_defaultbuff.dbr" doesn´t seem to apply.
By now, i don´t know why.
Maybe it´s a interference, where only the values come into use, which were called first.
In this case, the ones from the "battlestandard.dbr", 18 to 36.

All the other attributes from the Standard-Ability(blue text), are working fine.

Well, so what do we do ?
Leave the lifetime as it was, or change it somehow ?
I think the lifetime is a little bit to short.
Replacing the values from "battlestandard.dbr" with the ones from the
"battlestandard_petskill_defaultbuff.dbr", could be an idea.

---------------------------------------------------------------------------

So that´s it.
Any comments, opinions and cooperation are welcome.

Greetings,
GW

[lufe]

Guardian Warrior, first of all, thanks for bringing what you have already done on the german forum to us. Not only you made a huge effort to fix this bug (as Ganelon is doing) but you also translated everything and now come to help us get this fixed.

I can tell you that the issue is too much complicated for me; I've read it 2 times and I am in no condition to understand the specifics. But I think that between you and Ganelon, you 2 can get a good discussion this theme. While you're at it, maybe you can also discuss with him the Ravages of Time broken skill...?

All in all, thanks for joining!

[yerkyerk]

Well, I would have to study it too deep to really understand the mechanics. I'm not gonna apply this myself, but I hope Triumph will be fixed in the upcoming fanpatch that's being worked on, and this might be the chosen solution.

I just wanna say thanks for putting your time and effort in translating and working this out!

[GuardianWarrior]

Very very thanks to both of you.

I hope we can fix the major bugs sooner or later.
The more i hope is, that not more bugs appear, as with "Ravages of Time".
That was new to me, but maybe it can be fixed the same way as Triumph, lets hope.

[ShadowLich]

Originally Posted by GuardianWarrior

Well, so what do we do ?
Leave the lifetime as it was, or change it somehow ?
I think the lifetime is a little bit to short.
Replacing the values from "battlestandard.dbr" with the ones from the
"battlestandard_petskill_defaultbuff.dbr", could be an idea.

I reply here about the BS lifetime.
I didn't answer this question you're right.

Recharge time of BS is 60 sec. If using new time values at level 8 there would be no recharge time for BS...

For the ultimate levels I guess that 36 sec compared to 60 sec is already pretty much.

My mistake there, forgot to say "excellent job" btw

[yerkyerk]

Yea, I thought the Deathchill aura was weaker than it should be, but I never took the time to test it. Just wanna play without concerning myself about the bugs, you know? Glad to know at least some people think different

[ShadowLich]

I did your modification for Triumph to experiment in what it changes the way it works.
Since I did some modification on Ravages of Times (using Fatigue bonus for example) I try to adapt it. If it works I'll post it soon.

[Ganelon]

Originally Posted by GuardianWarrior

So the value from "skillActiveDuration" stops Triumph working after Standard disappeared.
Understand,
Triumph gets triggered in certain intervals.
The value from "skillActiveDuration" bridges the gap between the intervals, and
each triggered Triumph lasts again the X seconds set with "skillActiveDuration".
So Triumph lasts as long as the Standard does.

When doing my own experiments, I also noticed that Triumph turns on and off. In fact, it gets turned on and off in exact 4 second intervals. I was curious why this was happening, so I attached a soundfile to the activation and deactivation of Triumph. It turned out that the dumb AI kept trying to "recast" Triumph every 4 seconds, but because triumph is a toggle skill (the same class as Ring of Flame), "recasting" meant "turning it on and off.

I fixed this by changing the class of Triumph from Skill_BuffAttackRadius (eg Ring of Flame) to "Skill_BuffRadius" (the same class as Rally). Skill_BuffRadius CAN't be turned off, and so Triumph stays on. This is better than using the old toggle class and extending the duration of the effect because it means that monsters are affected within a second of entering the AoE, instead of at the start of the next 4 second cycle.

This still wasn't perfect. The dumb AI would keep trying to recast Triumph spell anyway. It can't turn it off anymore, so it's not so harmful, but the constant re-casting caused the Triumph effect to hiccup and fail randomly. I solved this issue by entering the Battle Standard pet dbrs and entering a large number for SpecialAttackDelay. This parameter governs the amount of time the AI will wait between recastings of a spell (incidentally, altering this number is how I fixed the Nymph AI).

3.
Triumph-Radius.
This on seems to be a little shorter than the one from Standard!
Take a char and go to the edge of the Standard-Radius, just before the
char-aura disappears. Lure a monster onto the same position beside your char,
so that it has the same distance to the Standard.
On that position the Debuffs of Triumph don´t work.
When you lure the monster just 2-3 steps nearer to the Standard,
Triumph starts to work.
Changing the distance profiles in 5) and 6), didn´t solve the problem,
except to make the Triumph-Radius far greater than the Standard-Radius.
But that´s not what we actually want to have.

Using Skill_BuffRadius seems to solve this issue. At least, I didn't have this problem.

4.
Flamewaves.
If you liked them, sorry, now they are gone.
I couldn´t manage it, to bring them back, but i was able to cast them on the enemies.
See ">>> Rename 5) and configure it <<< - e)" above, what to do.
Now the Flamewaves radiate from every enemy within Triumph range.
That´s very handy, cause it tells you when and at which radius Triumph starts to work.

I used this trick too. It's a great diagnostic!

I'll play around with tis later. It sounds like your solution is generally better than mine. I couldn't be happier. That means that we all get a better TQ.

[ShadowLich]

Yesterday I do all modifications with IT-artmanager and the Triumph skilled appeared "gray"
Ok I was (EDIT =>) very very tired.

This morning I make it works.
But as the -% damage resistance works very well the damage I received weren't modified. The mob has the flame aura to show that Triumph is active...
Since this is the part bugged in RoT...

[GuardianWarrior]

First i have to make an edit, because i did an important change somehow intuitively and therefore forgot to mention it. The distanceProfile of the Triumph-DBR has to be changed.
Changes are in red color:

---------------------------------------------------------------------------

Here are four short steps to get Triumph working:

>>> Make an empty mod <<<

>>> Rename 5) and configure it <<<
a)
Import "records\skills\warfare\battlestandard_petskill_tr iumph.dbr",
b)
Rename to "battlestandard_petskill_triumphbuff.dbr".
c)
From the menubar select "File/Set Template...", go into the Template-Folder and
select following file: "SkillBuff_Debuf.tpl".
d)
Open the file and go "All Groups/Cast Config" and
set "skillActiveDuration" onto 4 seconds.
(*this step is explained below, see point 1*)
e)
Go to "All Groups/Skill Config" and
set "distanceProfile" to "Moderate".
f)
(*Do this one if you like to have Flamewaves radiating from the monsters.*)
(*This step is explained below, see point 4.*)
Open "battlestandard_petskill_triumphbuff.dbr"
go to "All Groups/Skill Effects"
copy "Records\Effects\Warfare\WarBanner_FX01.dbr" from
"skillActivatedAuraName" to "skillCastAuraName".
g)
Click "File/Save".

>>> Make new DBR from old one <<<
a)
Import "records\skills\warfare\old\battlestandard_ski ll02 .dbr"
b)
Rename in "battlestandard_petskill_triumph.dbr" and copy to "records\skills\warfare\"
c)
Open the file and go "All Groups/Skill Config" onto DBR-Entry "buffSkillName",
and edit path and filename as follows:
"Records\Skills\Warfare\battlestandard_petskil l_tr iumphbuff.dbr"

>>> Build the mod with TQ- or IT-database.arz, it doesn´t matter which one. <<<

---------------------------------------------------------------------------

@Templates
Next thing i have to mention is, for the two new DBR-Files i have created:
battlestandard_petskill_triumph.dbr
battlestandard_petskill_triumphbuff.dbr
lots of different Template-Combos could be tested.
I have done a view, while working on my solution, but unfortunately i didn´t record the results. When i find myself enough time, i´ll do make those tests again and record them. On the other hand, the best result i could achive is the one i showed here.

As for the "Side Effects", from what i have seen now, while working on Triumph, i guess, no other Templates will fix them. The problem lies within the AI, i think.
But those "Side Effects" are just a minor issue and, for me, not worth investing a lot of time to fix them. Probably they are not fixable.


@Skill_BuffRadius.tpl
Yes, this on works also for the Triumph-Call-DBR: "battlestandard_petskill_triumph.dbr"
It solves "Point 4 - Flamewaves".
The now radiate again from the BS.
But, this Template also, does only work, if in the "battlestandard_petskill_triumphbuff.dbr" a timevalue is set here: "All Groups/Cast Config/skillActiveDuration". The 4 seconds, i suggested.


@Triumph-Radius
Using Skill_BuffRadius.tpl doesn´t solve this issue, in my tests.
Well, the radius difference is realy just a very little on and can easily be overlooked. Measured in char-steps, just 1-2.
I can make 2 or 3 pictures if you like.


@Ganelon

...I fixed this by changing the class of Triumph from Skill_BuffAttackRadius (eg Ring of Flame) to "Skill_BuffRadius" (the same class as Rally). Skill_BuffRadius CAN't be turned off, and so Triumph stays on. This is better than using the old toggle class and extending the duration of the effect because it means that monsters are affected within a second of entering the AoE, instead of at the start of the next 4 second cycle.

This still wasn't perfect. The dumb AI would keep trying to recast Triumph spell anyway. It can't turn it off anymore, so it's not so harmful, but the constant re-casting caused the Triumph effect to hiccup and fail randomly. I solved this issue by entering the Battle Standard pet dbrs and entering a large number for SpecialAttackDelay. This parameter governs the amount of time the AI will wait between recastings of a spell (incidentally, altering this number is how I fixed the Nymph AI).

If i have understood you right, you took the original Triumph-DBR, "battlestandard_petskill_triumph.dbr", and changed it´s original template(btw, Skill_BuffAttackRadiusToggled.tpl) ?
You didn´t create a Call-DBR for Triumph, as i have done in my solution ?
Ok, thats also one thing i didn´t test enough by now. I just took a view templates and tested them with original Triumph-DBR, without success. Maybe i have overlooked one, that could work.

In "Point 2" above i´ve mentioned, that i also experimented with "specialAttackDelay". Maybe my values were to small. I´ll have a new try on this.


@ShadowLich

...the damage I received weren't modified.

Hm, i´ve watched closely to HP changes, with BS+T and without. I could see a clear difference.
Did you max out Triumph ?
The -40 % on Level 6 make a huge difference.
And this debuff is only "physical" damage!
Hm, let´s wait, if someone else has this problem. More i can´t tell you right now.