Bugs and fixes for unofficial patch

[yerkyerk]

Originally Posted by Ganelon

Bug: Due to a database typo, the Nymph actually does less damage upon obtaining levels 19 and 20.

Bug: A broken loot table causes the hydra to drop double the number of helmets and no armbands http://www.titanquest.net/forums/spo...p-chances.html

Bug: The diseased plumage and venom sac charms sometimes don't yield a completion bonus. This is because their suffix table contains a reference to a bonus that doesn't exist. I think that the French got this one.

The first bug should definetely be looked after, that's just plain wrong (the little green wench is already so weak).
The second one is just plain annoying.. I hope someone will fix it, I guess it's easily overlooked.
I thought the 'Diseased' charm wasn't meant to give a bonus It is indeed fixed by the Frenchies. The OP also states that.

I won't add them for now though, the OP is actually only meant for bugs with fixes. Thanks for reporting though, hopefully someone will pick it up

Originally Posted by Arminia

Indeed

As I have done some research on unique loottables some time ago, I can offer corrected dbrs for those (only fixed obvious bugs), zip attached. Using them, all Uniques can drop (The Greg, Deathcuffs, Dark mark of Kalchas and loratian greaves were missing), and some drops are moved to the correct act.

I have added a detailed description of the changes to the zip-file as well.

Feel free to use the dbrs for any bugfix project you like, if possible, I'll add fixed lootmagicalaffix-dbrs sometime.

Ah, thank you very much

Originally Posted by Arminia

Concerning language: if you happen to be a nativ german speeker, we could discuss that topic via PN in german ...

The French Mod is linked to Ctrl+Alt+Suppr iirc, he might be the guy responsible for the French Mod. Well, maybe your French is better than mine

Originally Posted by WildeComputers

I was under the impression this was 'working-as-designed'. I believe this is an easy fix, but it never made it into Immortal Throne or patch 1.30.

After reading that thread, I concluded that nobody actually gave any good reason (it was just a hunch) for the bonuses not to exist. I do believe it is broken now. Also, Ganelon "This is because their suffix table contains a reference to a bonus that doesn't exist", which means there is indeed a reference.




Update: Well, I'm gonna make some updates. As you can see I already edited out the request for translation of the French patch, since we got the most important stuff translated and we seem to be moving on too fast to be concerned with that. I'll add in I_Raps fix for the messed up display of the Completed Anubis Relic and a part about additional features, e.g. custom skins. Read more about that here

I want to take this opportunity to thank everyone who's putting his sparetime in this project. I'm still a little concerned with the chaotic nature of it all though.

Also, I'd like to fill in a request; is it possible (and easy) to add cooldown times to skills? So that one can see how long it takes before a skill is usable again?

[Arminia]

Originally Posted by yerkyerk

...
The French Mod is linked to Ctrl+Alt+Suppr iirc, he might be the guy responsible for the French Mod. Well, maybe your French is better than mine
...

I got a hint on that from GuardianWarrior (yes, Ctrl+Alt+Suppr is from the french forum), and unfortunately my French simply does not exist, but so far communication in english seems work fine

[Ganelon]

Originally Posted by yerkyerk

The first bug should definetely be looked after, that's just plain wrong (the little green wench is already so weak).

The Nymph's bow is found in skills\nature\pets\slyvannymph_attack_Default.dbr. The last four levels of the offensivePierceMax variable read:

17: 80
18: 86
19: 73
20: 81

It looks like the programmer meant to type 93 instead of 73 and then propagated the error. I think that the following change is sensible:

19: 73 -> 93
20: 81 -> 101

After reading that thread, I concluded that nobody actually gave any good reason (it was just a hunch) for the bonuses not to exist. I do believe it is broken now. Also, Ganelon "This is because their suffix table contains a reference to a bonus that doesn't exist", which means there is indeed a reference.

Both of these charms have pretty high chance of spawning with the following bonus:

Records\Item\LootMagicalAffixes\AnimalRelics\Bonus es\Offensive_%Poison_01.dbr

This bonus doesn't exist. If I understand the French readme correctly, they solved this problem by simply eliminating the reference to the dud bonus. I think that it would be more in keeping with the original spirit of the game to simply create this bonus. We could use the elemental % bonuses as a guideline.

[Arminia]

Originally Posted by Ganelon

...
Both of these charms have pretty high chance of spawning with the following bonus:

Records\Item\LootMagicalAffixes\AnimalRelics\Bonus es\Offensive_%Poison_01.dbr

This bonus doesn't exist. If I understand the French readme correctly, they solved this problem by simply eliminating the reference to the dud bonus. I think that it would be more in keeping with the original spirit of the game to simply create this bonus. We could use the elemental % bonuses as a guideline.

It does exist, but they put a wrong path into the charms lootmagicalaffix, the correct one would be

Records\Item\LootMagicalAffixes\Relics\Bonuses\Off ensive_%Poison_01.dbr

simply changing to this will do. Btw, Offensive_%Poison_02.dbr and Offensive_%Poison_03.dbr does exist as well, the do have +10%, +20% and +25% poisondmg, resp.

[WildeComputers]

I was wondering if the patch shouldn't have an installer instead of having people copy files into their game directories. This would help those who are more worried about making a mistake or where English isn't their native language. However, it should be a Freeware or Open Source installer, so the patch doesn't run into legal snafus.

Here is one idea:
Nullsoft Scriptable Install System http://nsis.sourceforge.net/Main_Page

[yerkyerk]

@Ganelon: If it's so simple to adjust these values (I really have no idea), I'll put a link to your post in the OP. I think the way you suggest is indeed correct.

As for the non-existing bonus, does Arminia's suggestion work? Seems to be the simplest and best solution to the problem, I'll link to that post for the solution.

@WildeComputers; Yes, you are right. There should be an installer, this topic is meant to collect all fixes that should be put in a single patch file. Wasn't this clear? Perhaps I need to stress it better in the OP.

I have no idea if it's hard to put all those fixes in the installer and wether they can just be packed together or if most of it (database files) has to be in a single file. I hope someone is willing and able to pack them. It'd be good to pack them together in the near future, dubbing it the unofficial patch 1.2 beta or something along those lines.

There's been quite a few helpful changes so far, I think now's a good time to contact other boards and maybe some of the original developers to join us in completing the patch.

[GuardianWarrior]

Originally Posted by yerkyerk

... and maybe some of the original developers to join us in completing the patch.

Very good idea. I kept that in mind to, but thought to wait until problems appear, that seem to be unsolvable.

[yerkyerk]

Well yea, I'll probably make a thread about contacting others, since I think it's better if people who spoke with the developers on here contact them. Mainly for info, maybe they have some tips and tricks too.

Btw, I updated the Opening Post with another undecided additional feature, a camera mod.

[Vince the Conqueror]

This would be awesome! Any updates on this topic? How far is the progress on the patch?

[yerkyerk]

Well, it's currently being developed. If you read the Opening Post, you can see that it only just started, so it's a fresh project. It's being updated regularly. There's no real deadline for this project, as soon as the flow of fixes stop, the patch should be made solid. I know Guardianwarrior, Shadowlich, Ganelon and others have been busy working on important fixes.

Can't promise if this is really going through. The biggest obstacle I see is merging the stuff together, an experienced modder should be able to do this though. Lots of big bugs are already covered, I think enough to justify a new patch.