Bugs and fixes for unofficial patch

[yerkyerk]

Hehe, yea, that was me

I've made a thread about contacting people from outside (link), because I wanted to make sure none of the (bigger) communities were skipped. Nobody seems to reply to it, so I'm afraid I'm going to have to smite you all.

[I_Raps]

Here, now, stop that!

[Viper_Sweden]

*Thump...*

Seal of liking attached...

How many bugs will you deal with?

[Ganelon]

More news, and a few questions.

The issues with Triumph appear to be entirely surmounted. The last side effect has been eliminated, and I haven't seen any new issues. I'll release the finished package soon. I'd like at least a week of general testing before declaring this thing to be good enough for the patch.

ShadowLich has almost single-handedly vanquished the Ravages of Time bug, but some side effects remain. RoT is now a separate skill from Deathchill Aura. It has to be activated independently, and it no longer has Deathchill Aura as a prerequisite.

Personally, I think that this is a very reasonable price to pay for having a working version of RoT, but I've discovered that I have a very poor mindset for making these kinds of calls. What do other people think?

ShadowLich has an alternative solution that doesn't split Rot off from Deathchill Aura, but it deactivates the %Life Reduction effect of Deathchill, which is a pretty steep price to pay. I prefer the first solution.

Guardian Warrior discovered that the duration of Battle Standard doesn't continue to increase through the last four (Ultimate) levels. It looks like an accidental omission to me, but others might argue that this was an intentional feature. Extending the duration curve is a very east thing to do. Should it be included?

Also, I think that the patch should include the Immortal Throne templates. The Art Manager doesn't work properly without them, and right now, the only way to get them is through an obscure post on these forums.

http://www.titanquest.net/forums/que...tml#post122664

Also, see I_Raps' post about -recharge. He's found a solution that is much more parsimonious than the French work around.

[ShadowLich]

Originally Posted by Ganelon

ShadowLich has almost single-handedly vanquished the Ravages of Time bug, but some side effects remain. RoT is now a separate skill from Deathchill Aura. It has to be activated independently, and it no longer has Deathchill Aura as a prerequisite.

Normally it is... you need 1 skill point in DCA to put 1 in RoT.
Still RoT can be activated without DCA, maybe that was only what you mean...

Originally Posted by Ganelon

Guardian Warrior discovered that the duration of Battle Standard doesn't continue to increase through the last four (Ultimate) levels. It looks like an accidental omission to me, but others might argue that this was an intentional feature. Extending the duration curve is a very east thing to do. Should it be included?

Duration is 36 sec for 60 sec of recharge time. In front of the power you get with it (even before you both fixed it), I think it would be insane to put 44 sec at level 14... It's 3/4 of the time you fight with it that way.
In my opinion BS is way too powerfull now. IL didn't lower it because it never works...

[yerkyerk]

I'll post the link to the final Triumph fix when you 3 guys decided and posted what fix would be the best. Once again, great job!

I agree that the first RoT fix is best and would be a fitting fix. Not much loss there and a lot of gain. I've got 2 questions about it though; does it reduce both physical and pierce damage? Does it reduce more damage types?
I've also added the IT templates, I'm not sure as to what their function is, but I deduced that it's a very welcome addition for modders.
Well, I'd say let's just leave BS as it is (some skills don't level logically in IT anyway). If necessary, we can always decide to change that in a might-be balance patch or a minor fixpatch update. But that's just my opinion.


Also, I think we need to have all fixes that are present in the French update. Here's their list, what we've fixed is green, what we didn't (or I oversaw something) is red
- Rewards for the Stygian Lurker quest
- Bugged Homados/Barbarian's Spiked greaves
- Armour on Ismene's Bracers
- Drop rates for Ismene's Helm/Revenant Greaves/Bloodborn Leggings
- Completion bonuses for Venom Sac/Diseased Plumage
- Fix/workaround for -Recharge% affixes/Shaman's MI sets/Scroll of Archmage's Fury
- Some minor graphics bugs
The drops are all data-based errors, I know Arminia made some change to these, but I don't think he included the red ones.

Update:
I_Raps fix -recharge fix is noticed and added
Nymph fix and camera mod are removed
Changed link to Golden Fleece fix (wasn't correct, thanks I_Raps)
Added IT Templates

[Ganelon]

Originally Posted by yerkyerk

I'll post the link to the final Triumph fix when you 3 guys decided and posted what fix would be the best. Once again, great job!

I agree that the first RoT fix is best and would be a fitting fix. Not much loss there and a lot of gain. I've got 2 questions about it though; does it reduce both physical and pierce damage? Does it reduce more damage types?

It does exactly what it says it does, and no more. Physical and pierce are both clearly affected. The other damage types are not. Presumably, the -Armor Absorption effect works as well, but this is hard to test quantitatively.

[GuardianWarrior]

Originally Posted by yerkyerk

... Well, I'd say let's just leave BS as it is (some skills don't level logically in IT anyway). If necessary, we can always decide to change that in a might-be balance patch or a minor fixpatch update. But that's just my opinion.

Totaly agreed. As you stated elsewhere before, the first patch should just contain fixes, balancing issues should be in later patches.
So let the people play a while with the first release and collect their experiance. With this gathered background, we could go in for balancing issues.

Originally Posted by yerkyerk

...
Also, I think we need to have all fixes that are present in the French update. Here's their list, what we've fixed is green, what we didn't (or I oversaw something) is red
- Rewards for the Stygian Lurker quest
- Bugged Homados/Barbarian's Spiked greaves
- Armour on Ismene's Bracers
- Drop rates for Ismene's Helm/Revenant Greaves/Bloodborn Leggings
- Completion bonuses for Venom Sac/Diseased Plumage
- Fix/workaround for -Recharge% affixes/Shaman's MI sets/Scroll of Archmage's Fury
- Some minor graphics bugs
The drops are all data-based errors, I know Arminia made some change to these, but I don't think he included the red ones.

Do we have all bugs collected by now ?
Whats with this one:
- The +%Armor Protection completion bonus for Theban and Battlemage sets does not work.
I have found it in this list.

[Arminia]

Originally Posted by yerkyerk

...
- Bugged Homados/Barbarian's Spiked greaves
...

Oops, forgot to say, that's an easy one. I'll try to explain:

for most stats you'll have 2 entries in the database, something like PhysicalDamage and PhysicalDamageModifier, 1st one to be some sort of absolute value, last one to be some percentage. Now damage is calculated like sum(PhysicalDamage)*(1+sum(PhysicalDamageModifier)/100).

Same holds for stats like speed, whereas here you'll have the following confusing matters: absolute speed figures are given like 0.74 (meaning a speed of 74%, and showing like this ingame), whereas modifiers are given like 25.0 (meaning an additionally 25%). If you have those two figures (the 0.74 is the base attack-speed of any character, btw), your AS will be 0.74*(1.25)=0.925, and not 0.99, as one might guess.

Now most Speed-stats are given as Modifiers, except those of Homados and Barbarian spiked greaves. And here the developers went wrong, they put an absolute value of 10.0 to those items (giving a speed of 10.74 = 1074%, including the characters base-speed, which is way above any caps), that's why Homados maxes your AS.

In the attached drbs I have corrected this to 0.1 (as this seems to be the intention, to add 10% absolute). Additionally I have fixed the epic sentinels gloves, as they only gave +1 to hunting. As normal gives +1 and legendary gives +3, and SBC give +1/+2/+3 as well, I'd call this a bug and not a feature as well.

Corrected dbrs attached,
Arminia

[GuardianWarrior]

BUGFIX "Divine Scroll of the Archmage`s Fury"